On Mon, 2020-03-30 at 14:35 +0100, Jonathan Cameron wrote: > On Sun, 29 Mar 2020 11:19:15 +0100 > Jonathan Cameron <jic23@xxxxxxxxxx> wrote: > > > On Thu, 26 Mar 2020 19:45:39 +0000 > > "Ardelean, Alexandru" <alexandru.Ardelean@xxxxxxxxxx> wrote: > > > > > On Thu, 2020-03-26 at 12:56 -0600, Rob Herring wrote: > > > > On Tue, 24 Mar 2020 15:46:36 +0200, Alexandru Ardelean wrote: > > > > > This change adds the binding doc for the AD9467 ADC. > > > > > > > > > > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@xxxxxxxxxx> > > > > > --- > > > > > .../bindings/iio/adc/adi,ad9467.yaml | 65 > > > > > +++++++++++++++++++ > > > > > 1 file changed, 65 insertions(+) > > > > > create mode 100644 > > > > > Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml > > > > > > > > > > > > > Please add Acked-by/Reviewed-by tags when posting new versions. However, > > > > there's no need to repost patches *only* to add the tags. The upstream > > > > maintainer will do that for acks received on the version they apply. > > > > > > > > If a tag was not added on purpose, please state why and what > > > > changed. > > > > > > My bad. Apologies for that. > > > No idea how I missed adding this. Especially since I already know that I > > > should > > > add it. > > > > > > I guess I got mixed up with too many branches and not paying attention. > > Fixed the missing tag from Rob and whole series applied to the togreg branch > > of > > iio.git. Pushed out as testing for the autobuilders to poke at it. > > > > Exposing the dma buffer stuff to the autobuilders is great. So far the only > > issue was that patch I took yesterday where we need to rethink things. > > However, that's just my sanity check local build so I'm sure we broke > > some obscure architecture :) > > 0-day found some issues in the series.. Note I think this is the list that > hasn't been human sanity checked yet so can be 'interesting'. > > drivers/iio/adc/ad9467.c:288:13: warning: Checking if unsigned expression > 'r_clk' is less than zero. [unsignedLessThanZero] > r_clk = clock_round_rate that can indeed return a negative (long) > I've dropped the unsigned given we check for negative so this should be safe. > > drivers/iio/adc/ad9467.c:381:7: warning: Variable 'ret' is assigned a value > that is never used. [unreadVariable] > Missing error check. I've added it. Please sanity check in the testing branch. > > > drivers/iio/adc/adi-axi-adc.c:158:18: warning: The scope of the variable > 'ctrl' can be reduced. [variableScope] > This one is silly. Sure you could reduce the scope, but there is little risk > in not doing so given all the > function contains is one loop. > > drivers/iio/adc/adi-axi-adc.c:354:32: warning: Redundant assignment of 'conv' > to itself. [selfAssignment] > This one is real. Fixed up. conv = conv = st->... Oops. May have been copy + paste err. > > drivers/iio/adc/adi-axi-adc.c:355:9: warning: The scope of the variable 'ret' > can be reduced. [variableScope] > Again, somewhat silly. > > So I've ignored 2 of them. We 'could' fix these but until I get the feeling > the kernel coding style has actually changed to specify this rather than it > being a matter of taste I'm not particularly inclined to do so. Thanks for taking care of them. The scope reduction warnings are getting a bit popular with static-checkers. Let's see how that evolves later. I feel they might be coming along the same way as checkpatch stuff. > > Thanks, > > Jonathan > > > Thanks, > > > > Jonathan > > > >
