On Sun, 22 Mar 2020 22:53:15 +0530 Nishant Malpani <nish.malpani25@xxxxxxxxx> wrote: > Utilize %pe format specifier from vsprintf while printing error logs > with dev_err(). Discards the use of unnecessary explicit casting and > prints symbolic error name which might prove to be convenient during > debugging. > > Signed-off-by: Nishant Malpani <nish.malpani25@xxxxxxxxx> Applied, Thanks, Jonathan > --- > > Changes in v2: > - Rewrite commit subject line outlining the usage of %pe. > - Add a separator between regmap and its error name. > > Based on conversations in [1] & [2]. > > [1] https://marc.info/?l=linux-iio&m=158427554607223&w=2 > [2] https://marc.info/?l=linux-iio&m=158481647605891&w=2 > --- > drivers/iio/magnetometer/bmc150_magn_spi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/magnetometer/bmc150_magn_spi.c b/drivers/iio/magnetometer/bmc150_magn_spi.c > index ed9be0490d77..c6ed3ea8460a 100644 > --- a/drivers/iio/magnetometer/bmc150_magn_spi.c > +++ b/drivers/iio/magnetometer/bmc150_magn_spi.c > @@ -22,8 +22,8 @@ static int bmc150_magn_spi_probe(struct spi_device *spi) > > regmap = devm_regmap_init_spi(spi, &bmc150_magn_regmap_config); > if (IS_ERR(regmap)) { > - dev_err(&spi->dev, "Failed to register spi regmap %d\n", > - (int)PTR_ERR(regmap)); > + dev_err(&spi->dev, "Failed to register spi regmap: %pe\n", > + regmap); > return PTR_ERR(regmap); > } > return bmc150_magn_probe(&spi->dev, regmap, spi->irq, id->name);
