Re: [PATCH v4 2/5] mfd: mp2629: Add support for mps battery charger

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andy,

On 27/03/20 1:56 pm, Andy Shevchenko wrote:
On Fri, Mar 27, 2020 at 2:41 PM saravanan sekar <sravanhome@xxxxxxxxx> wrote:
On 27/03/20 12:25 pm, Lee Jones wrote:
On Fri, 27 Mar 2020, saravanan sekar wrote:
On 27/03/20 11:22 am, Lee Jones wrote:
So Andy has reviewed, but you still don't have him on Cc?
Sorry one of his hint made me removed him in CC unknowingly.

"For the future, hint:
          scripts/get_maintainer.pl --git --git-min-percent=67 ..."

Perhaps I have to elaborate. The above hint for the initial submit.
Then the rule of thumb: Include reviewers into Cc (to the patches they
have reviewed), because you can't know their intention and maybe they
want to follow a development.
Thanks for more details. Between Lee has not recommended "forward declarations", the review comment you gave on my V1 patch (more info on previous email). Hope you agree with the same.
My fault, added him in CC
No problem.

--
With Best Regards,
Andy Shevchenko



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux