On Mon, Mar 23, 2020 at 11:41 AM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> With DEBUG_SHIRQ enabled we have a kernel crash
>
> [ 116.482696] BUG: kernel NULL pointer dereference, address: 0000000000000000
>
> ...
>
> [ 116.606571] Call Trace:
> [ 116.609023] <IRQ>
> [ 116.611047] complete+0x34/0x50
> [ 116.614206] bmp085_eoc_irq+0x9/0x10 [bmp280]
>
> because DEBUG_SHIRQ mechanism fires an IRQ before registration and drivers
> ought to be able to handle an interrupt happening before request_irq() returns.
>
> Fixes: aae953949651 ("iio: pressure: bmp280: add support for BMP085 EOC interrupt")
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
> v2: put conditional logic back when re-initializing completion (Jonathan)
Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
Yours,
Linus Walleij
