On Mon, Mar 23, 2020 at 01:40:08AM +0200, Andy Shevchenko wrote:
> On Sun, Mar 22, 2020 at 9:57 PM Deepak R Varma <mh12gx2825@xxxxxxxxx> wrote:
> >
> > Three macros include SYNC in their names which is a typo. Update those
> > names to SINC.
>
> It is good to elaborate the source of the above statement (e.g.
> datasheet pages).
>
> > Fixes: 77f6a23092c0 ("staging: iio: adc: ad7192: Add low_pass_3db_filter_frequency")
>
> >
>
> This blank line should go before Fixes tag. The rule is that tags are
> forming a block at the end of commit message.
>
> > Signed-off-by: Deepak R Varma <mh12gx2825@xxxxxxxxx>
> > Suggested-by: Lars-Peter Clausen <lars@xxxxxxxxxx>
>
> The code below looks good to me.
Thank you for your feedback. I agree with your comments. I will update
and send this back as next version.
Deepak.
>
>
> >
> > ---
> >
> > Changes since v2:
> > - None. Version increment to follow patch series versioning.
> >
> > Changes since v1:
> > - None. Patch added in v2 version as suggested by Stefano.
> >
> >
> > drivers/iio/adc/ad7192.c | 20 ++++++++++----------
> > 1 file changed, 10 insertions(+), 10 deletions(-)
> >
> > diff --git a/drivers/iio/adc/ad7192.c b/drivers/iio/adc/ad7192.c
> > index 02981f3d1794..d9a220d4217f 100644
> > --- a/drivers/iio/adc/ad7192.c
> > +++ b/drivers/iio/adc/ad7192.c
> > @@ -144,9 +144,9 @@
> > #define AD7192_EXT_FREQ_MHZ_MAX 5120000
> > #define AD7192_INT_FREQ_MHZ 4915200
> >
> > -#define AD7192_NO_SYNC_FILTER 1
> > -#define AD7192_SYNC3_FILTER 3
> > -#define AD7192_SYNC4_FILTER 4
> > +#define AD7192_NO_SINC_FILTER 1
> > +#define AD7192_SINC3_FILTER 3
> > +#define AD7192_SINC4_FILTER 4
> >
> > /* NOTE:
> > * The AD7190/2/5 features a dual use data out ready DOUT/RDY output.
> > @@ -367,7 +367,7 @@ static int ad7192_setup(struct ad7192_state *st, struct device_node *np)
> > st->conf |= AD7192_CONF_REFSEL;
> >
> > st->conf &= ~AD7192_CONF_CHOP;
> > - st->f_order = AD7192_NO_SYNC_FILTER;
> > + st->f_order = AD7192_NO_SINC_FILTER;
> >
> > buf_en = of_property_read_bool(np, "adi,buffer-enable");
> > if (buf_en)
> > @@ -484,11 +484,11 @@ static void ad7192_get_available_filter_freq(struct ad7192_state *st,
> >
> > /* Formulas for filter at page 25 of the datasheet */
> > fadc = DIV_ROUND_CLOSEST(st->fclk,
> > - AD7192_SYNC4_FILTER * AD7192_MODE_RATE(st->mode));
> > + AD7192_SINC4_FILTER * AD7192_MODE_RATE(st->mode));
> > freq[0] = DIV_ROUND_CLOSEST(fadc * 240, 1024);
> >
> > fadc = DIV_ROUND_CLOSEST(st->fclk,
> > - AD7192_SYNC3_FILTER * AD7192_MODE_RATE(st->mode));
> > + AD7192_SINC3_FILTER * AD7192_MODE_RATE(st->mode));
> > freq[1] = DIV_ROUND_CLOSEST(fadc * 240, 1024);
> >
> > fadc = DIV_ROUND_CLOSEST(st->fclk, AD7192_MODE_RATE(st->mode));
> > @@ -576,25 +576,25 @@ static int ad7192_set_3db_filter_freq(struct ad7192_state *st,
> >
> > switch (idx) {
> > case 0:
> > - st->f_order = AD7192_SYNC4_FILTER;
> > + st->f_order = AD7192_SINC4_FILTER;
> > st->mode &= ~AD7192_MODE_SINC3;
> >
> > st->conf |= AD7192_CONF_CHOP;
> > break;
> > case 1:
> > - st->f_order = AD7192_SYNC3_FILTER;
> > + st->f_order = AD7192_SINC3_FILTER;
> > st->mode |= AD7192_MODE_SINC3;
> >
> > st->conf |= AD7192_CONF_CHOP;
> > break;
> > case 2:
> > - st->f_order = AD7192_NO_SYNC_FILTER;
> > + st->f_order = AD7192_NO_SINC_FILTER;
> > st->mode &= ~AD7192_MODE_SINC3;
> >
> > st->conf &= ~AD7192_CONF_CHOP;
> > break;
> > case 3:
> > - st->f_order = AD7192_NO_SYNC_FILTER;
> > + st->f_order = AD7192_NO_SINC_FILTER;
> > st->mode |= AD7192_MODE_SINC3;
> >
> > st->conf &= ~AD7192_CONF_CHOP;
> > --
> > 2.17.1
> >
>
>
> --
> With Best Regards,
> Andy Shevchenko
