On Sat, 2020-03-21 at 15:55 +0530, DEEPAK VARMA wrote: > [External] > > On Thu, Mar 19, 2020 at 09:46:10PM +0530, DEEPAK VARMA wrote: > > On Thu, Mar 19, 2020 at 07:07:20AM +0000, Ardelean, Alexandru wrote: > > > On Thu, 2020-03-19 at 08:03 +0100, Julia Lawall wrote: > > > > [External] > > > > > > > > > > > > > > > > On Thu, 19 Mar 2020, Ardelean, Alexandru wrote: > > > > > > > > > On Wed, 2020-03-18 at 22:30 +0530, DEEPAK VARMA wrote: > > > > > > [External] > > > > > > > > > > > > On Wed, Mar 18, 2020 at 05:28:17PM +0100, Julia Lawall wrote: > > > > > > > On Wed, 18 Mar 2020, DEEPAK VARMA wrote: > > > > > > > > > > > > > > > On Wed, Mar 18, 2020 at 04:19:24PM +0100, Greg KH wrote: > > > > > > > > > On Wed, Mar 18, 2020 at 04:12:28PM +0100, Lars-Peter Clausen > > > > > > > > > wrote: > > > > > > > > > > On 3/18/20 7:00 AM, Greg KH wrote: > > > > > > > > > > > On Wed, Mar 18, 2020 at 09:58:13AM +0530, Deepak R Varma > > > > > > > > > > > wrote: > > > > > > > > > > > > Add spaces around operator symbols to improve > > > > > > > > > > > > readability. > > > > > > > > > > > > Warning > > > > > > > > > > > > flagged by checkpatch script. > > > > > > > > > > > > > > > > > > > > > > > > Signed-off-by: Deepak R Varma <mh12gx2825@xxxxxxxxx> > > > > > > > > > > > > --- > > > > > > > > > > > > drivers/staging/iio/adc/ad7280a.c | 4 ++-- > > > > > > > > > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > > > > > > > > > > > > > > > > > diff --git a/drivers/staging/iio/adc/ad7280a.c > > > > > > > > > > > > b/drivers/staging/iio/adc/ad7280a.c > > > > > > > > > > > > index 19a5f244dcae..34ca0d09db85 100644 > > > > > > > > > > > > --- a/drivers/staging/iio/adc/ad7280a.c > > > > > > > > > > > > +++ b/drivers/staging/iio/adc/ad7280a.c > > > > > > > > > > > > @@ -825,14 +825,14 @@ static irqreturn_t > > > > > > > > > > > > ad7280_event_handler(int > > > > > > > > > > > > irq, void *private) > > > > > > > > > > > > } > > > > > > > > > > > > static IIO_DEVICE_ATTR_NAMED(in_thresh_low_value, > > > > > > > > > > > > - in_voltage- > > > > > > > > > > > > voltage_thresh_low_value, > > > > > > > > > > > > + in_voltage - > > > > > > > > > > > > voltage_thresh_low_value, > > > > > > > > > > > > 0644, > > > > > > > > > > > > ad7280_read_channel_config, > > > > > > > > > > > > ad7280_write_channel_config > > > > > > > > > > > > , > > > > > > > > > > > > AD7280A_CELL_UNDERVOLTAGE); > > > > > > > > > > > > static IIO_DEVICE_ATTR_NAMED(in_thresh_high_value, > > > > > > > > > > > > - in_voltage- > > > > > > > > > > > > voltage_thresh_high_value, > > > > > > > > > > > > + in_voltage - > > > > > > > > > > > > voltage_thresh_high_value, > > > > > > > > > > > > 0644, > > > > > > > > > > > > ad7280_read_channel_config, > > > > > > > > > > > > ad7280_write_channel_config > > > > > > > > > > > > , > > > > > > > > > > > > > > > > > > > > > > Did you try building this code? > > > > > > > > > > > > > > > > > > > > > > It catches everyone... > > > > > > > > > > > > > > > > > > > > The problem is it builds. The token is stringyfied and > > > > > > > > > > "in_voltage - voltage_thresh_high_value" is a valid string. > > > > > > > > > > > > > > > > > > Ah, I thought it used to break the build when it happened. Oh > > > > > > > > > well, > > > > > > > > > it's still a great "trick" to see if people understand C or > > > > > > > > > not :) > > > > > > > > > > > > > > > > > Yes, it did build. I am sorry but I am not following you fully. > > > > > > > > Can > > > > > > > > you > > > > > > > > please let me know if the change I introduced is not good. You > > > > > > > > may > > > > > > > > please direct me to a document where I can read more about it. > > > > > > > > > > > > > > The code involves a macro, as indicated by the capital > > > > > > > letters. You > > > > > > > will > > > > > > > see the issue when you look at the definition of the macro. > > > > > > > > > > > > > > julia > > > > > > > > > > > > Thank you Julia and all. I got my mistake. I will revert the change. > > > > > > Sorry for the trouble. > > > > > > > > > > I'll try to make some time to address this somehow, so that checkpatch > > > > > doesn't > > > > > bump into this. > > > > > > > > > > In the last 2-3 years, I think I saw 3-4 patches trying to address > > > > > this [for > > > > > various Analog drivers]. > > > > > So, don't feel too bad. > > > > > > > > Maybe a comment? > > > > > > Comment works for now. > > > Anybody wants to do a patch for that? > > > If nobody sends a patch for this in 1-2 weeks, I'll send one. > > > > > > Particularly, this would help with review, since people that are > > > unfamiliar with > > > IIO-specific macros would also find it easier at review. > > > > > > The good part, is that it's only needed for AD7280A. > > > AD7192 has been re-worked, and is no longer on checkpatch's radar. > > > I'm reworking AD7793 now. > > > > > > > I will be happy to add a comment around the code area to indicate > > ignore checkpatch warning for the mentioned argument. Please confirm if > > that is what you are expecting to be done. > > > > Hello Alexandru, > could you please confirm if I should add a comment around the code in > ad7280a.c to avoid further changes being made to the string argument? Sure. Please send a patch. [ I already replied this a few days ago; must have gotten lost in some emails ] > > > > Thanks, > > Deepak. > > > > > > julia > > > > > > > > > > Deepak. > > > > > > > > Thanks, > > > > > > > > Deepak. > > > > > > > > > thanks, > > > > > > > > > > > > > > > > > > greg k-h > > > > > > > > > > > > > > > > -- > > > > > > > > You received this message because you are subscribed to the > > > > > > > > Google > > > > > > > > Groups > > > > > > > > "outreachy-kernel" group. > > > > > > > > To unsubscribe from this group and stop receiving emails from > > > > > > > > it, send > > > > > > > > an > > > > > > > > email to outreachy-kernel+unsubscribe@xxxxxxxxxxxxxxxx. > > > > > > > > To view this discussion on the web visit > > > > > > > > https://urldefense.com/v3/__https://groups.google.com/d/msgid/outreachy-kernel/20200318162353.GA23226*40deeUbuntu__;JQ!!A3Ni8CS0y2Y!uU95kG8KOMvTxz7PtgIm2gziXrrKPEfRDslhYEuDsrhPhXlYxaYcX-70a6Ipi1oLtgyinw$ > > > > > > > > . > > > > > > > >
