Re: [PATCH 2/2] staging: iio: adc: ad7280a: Add spaces around operators

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 3/18/20 7:00 AM, Greg KH wrote:
On Wed, Mar 18, 2020 at 09:58:13AM +0530, Deepak R Varma wrote:
Add spaces around operator symbols to improve readability. Warning
flagged by checkpatch script.

Signed-off-by: Deepak R Varma <mh12gx2825@xxxxxxxxx>
---
  drivers/staging/iio/adc/ad7280a.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c
index 19a5f244dcae..34ca0d09db85 100644
--- a/drivers/staging/iio/adc/ad7280a.c
+++ b/drivers/staging/iio/adc/ad7280a.c
@@ -825,14 +825,14 @@ static irqreturn_t ad7280_event_handler(int irq, void *private)
  }
static IIO_DEVICE_ATTR_NAMED(in_thresh_low_value,
-			     in_voltage-voltage_thresh_low_value,
+			     in_voltage - voltage_thresh_low_value,
  			     0644,
  			     ad7280_read_channel_config,
  			     ad7280_write_channel_config,
  			     AD7280A_CELL_UNDERVOLTAGE);
static IIO_DEVICE_ATTR_NAMED(in_thresh_high_value,
-			     in_voltage-voltage_thresh_high_value,
+			     in_voltage - voltage_thresh_high_value,
  			     0644,
  			     ad7280_read_channel_config,
  			     ad7280_write_channel_config,

Did you try building this code?

It catches everyone...

The problem is it builds. The token is stringyfied and
"in_voltage - voltage_thresh_high_value" is a valid string.

- Lars



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux