On Wed, Mar 18, 2020 at 08:42:45PM +0530, DEEPAK VARMA wrote:
> On Wed, Mar 18, 2020 at 07:00:04AM +0100, Greg KH wrote:
> > On Wed, Mar 18, 2020 at 09:56:59AM +0530, Deepak R Varma wrote:
> > > Macro arguments are computed at the time of macro invocation. This makes
> > > the lines cross 80 column width. Add variables to perform the
> > > calculations before hand and use these new variable in the macro calls
> > > instead.
> > >
> > > Also re-indent enum members to address checkpatch warning / check messages.
> >
> > When you say "also" in a changelog description, that's a huge hint the
> > patch needs to be broken up.
> >
> > And that is what needs to happen here.
> >
> > >
> > > Signed-off-by: Deepak R Varma <mh12gx2825@xxxxxxxxx>
> > > ---
> > > drivers/staging/iio/adc/ad7192.c | 15 ++++++++-------
> > > 1 file changed, 8 insertions(+), 7 deletions(-)
> > >
> > > diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
> > > index bf3e2a9cc07f..0265f6607d75 100644
> > > --- a/drivers/staging/iio/adc/ad7192.c
> > > +++ b/drivers/staging/iio/adc/ad7192.c
> > > @@ -156,8 +156,8 @@
> > > */
> > >
> > > enum {
> > > - AD7192_SYSCALIB_ZERO_SCALE,
> > > - AD7192_SYSCALIB_FULL_SCALE,
> > > + AD7192_SYSCALIB_ZERO_SCALE,
> > > + AD7192_SYSCALIB_FULL_SCALE,
> >
> > Because this has nothing to do with the subject, please make it a
> > separate patch.
> >
>
> Okay. Got your point. I was thinking since this is a clean up patch I can include both
> the changes for the same file in a single patch. No problem; I will
> correct and send in a v2.
>From my patch bot which would have normally triggered on this patch had
it not been part of the outrechy project:
- Your patch did many different things all at once, making it difficult
to review. All Linux kernel patches need to only do one thing at a
time. If you need to do multiple things (such as clean up all coding
style issues in a file/driver), do it in a sequence of patches, each
one doing only one thing. This will make it easier to review the
patches to ensure that they are correct, and to help alleviate any
merge issues that larger patches can cause.
