On Wed, 18 Mar 2020 09:56:59 +0530
Deepak R Varma <mh12gx2825@xxxxxxxxx> wrote:
> Macro arguments are computed at the time of macro invocation. This makes
> the lines cross 80 column width. Add variables to perform the
> calculations before hand and use these new variable in the macro calls
> instead.
>
> Also re-indent enum members to address checkpatch warning / check messages.
>
> Signed-off-by: Deepak R Varma <mh12gx2825@xxxxxxxxx>
> ---
> drivers/staging/iio/adc/ad7192.c | 15 ++++++++-------
> 1 file changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
> index bf3e2a9cc07f..0265f6607d75 100644
> --- a/drivers/staging/iio/adc/ad7192.c
> +++ b/drivers/staging/iio/adc/ad7192.c
> @@ -156,8 +156,8 @@
> */
>
> enum {
> - AD7192_SYSCALIB_ZERO_SCALE,
> - AD7192_SYSCALIB_FULL_SCALE,
> + AD7192_SYSCALIB_ZERO_SCALE,
> + AD7192_SYSCALIB_FULL_SCALE,
> };
>
> struct ad7192_state {
> @@ -477,17 +477,18 @@ static ssize_t ad7192_set(struct device *dev,
> }
>
> static void ad7192_get_available_filter_freq(struct ad7192_state *st,
> - int *freq)
> + int *freq)
> {
> unsigned int fadc;
> + unsigned int sync3_filter, sync4_filter;
>
> /* Formulas for filter at page 25 of the datasheet */
> - fadc = DIV_ROUND_CLOSEST(st->fclk,
> - AD7192_SYNC4_FILTER * AD7192_MODE_RATE(st->mode));
> + sync4_filter = AD7192_SYNC4_FILTER * AD7192_MODE_RATE(st->mode);
Have you read page 25 of the datasheet? Why is this called
sync4_filter, with a 'y'?
--
Stefano
