Use the IIO_DEVICE_ATTR_RO macro to create the device attributes. Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> --- drivers/iio/pressure/bmp280-core.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/iio/pressure/bmp280-core.c b/drivers/iio/pressure/bmp280-core.c index 5e229b95308e..25be3ff1a6ab 100644 --- a/drivers/iio/pressure/bmp280-core.c +++ b/drivers/iio/pressure/bmp280-core.c @@ -588,7 +588,7 @@ static ssize_t bmp280_show_avail(char *buf, const int *vals, const int n) return len; } -static ssize_t bmp280_show_temp_oversampling_avail(struct device *dev, +static ssize_t in_temp_oversampling_ratio_available_show(struct device *dev, struct device_attribute *attr, char *buf) { struct bmp280_data *data = iio_priv(dev_to_iio_dev(dev)); @@ -596,8 +596,9 @@ static ssize_t bmp280_show_temp_oversampling_avail(struct device *dev, return bmp280_show_avail(buf, data->chip_info->oversampling_temp_avail, data->chip_info->num_oversampling_temp_avail); } +static IIO_DEVICE_ATTR_RO(in_temp_oversampling_ratio_available, 0); -static ssize_t bmp280_show_press_oversampling_avail(struct device *dev, +static ssize_t in_pressure_oversampling_ratio_available_show(struct device *dev, struct device_attribute *attr, char *buf) { struct bmp280_data *data = iio_priv(dev_to_iio_dev(dev)); @@ -605,17 +606,12 @@ static ssize_t bmp280_show_press_oversampling_avail(struct device *dev, return bmp280_show_avail(buf, data->chip_info->oversampling_press_avail, data->chip_info->num_oversampling_press_avail); } - -static IIO_DEVICE_ATTR(in_temp_oversampling_ratio_available, - S_IRUGO, bmp280_show_temp_oversampling_avail, NULL, 0); - -static IIO_DEVICE_ATTR(in_pressure_oversampling_ratio_available, - S_IRUGO, bmp280_show_press_oversampling_avail, NULL, 0); +static IIO_DEVICE_ATTR_RO(in_pressure_oversampling_ratio_available, 0); static struct attribute *bmp280_attributes[] = { &iio_dev_attr_in_temp_oversampling_ratio_available.dev_attr.attr, &iio_dev_attr_in_pressure_oversampling_ratio_available.dev_attr.attr, - NULL, + NULL }; static const struct attribute_group bmp280_attrs_group = { -- 2.25.1