On Wed, 4 Mar 2020 06:35:28 +0000 "Ardelean, Alexandru" <alexandru.Ardelean@xxxxxxxxxx> wrote: > On Mon, 2020-03-02 at 21:32 +0800, YueHaibing wrote: > > [External] > > > > It seems ad7797_attribute_group should be used in ad7797_info, > > according to commit ("iio:ad7793: Add support for the ad7796 and ad7797"). > > While the change looks good at first, I am thinking that this might introduce > another issue while fixing this one. > > It looks like the ad7797_attributes[] array may also require the > &iio_dev_attr_in_m_in_scale_available.dev_attr.attr attribute as well. > It looks like the available scales should be printed for AD7997 as well. > > That being said, this patch is fine as-is. > But it would require a patch [before-this-patch] to fix the ad7797_attributes > array. > > Something like this: > > static struct attribute *ad7797_attributes[] = { > &iio_const_attr_sampling_frequency_available_ad7797.dev_attr.attr, > + &iio_dev_attr_in_m_in_scale_available.dev_attr.attr, > NULL > }; > > I'm hoping I'm right about this one. I sometimes don't notice things too well. Agreed. Should have that addition as well. If not we'll successfully fix one issue but drop a valid interface at the same time... Thanks, Jonathan > > > > > Fixes: fd1a8b912841 ("iio:ad7793: Add support for the ad7796 and ad7797") > > Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx> > > --- > > drivers/iio/adc/ad7793.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/iio/adc/ad7793.c b/drivers/iio/adc/ad7793.c > > index b747db9..e5691e3 100644 > > --- a/drivers/iio/adc/ad7793.c > > +++ b/drivers/iio/adc/ad7793.c > > @@ -542,7 +542,7 @@ static const struct iio_info ad7797_info = { > > .read_raw = &ad7793_read_raw, > > .write_raw = &ad7793_write_raw, > > .write_raw_get_fmt = &ad7793_write_raw_get_fmt, > > - .attrs = &ad7793_attribute_group, > > + .attrs = &ad7797_attribute_group, > > .validate_trigger = ad_sd_validate_trigger, > > }; > >