Re: [PATCH v2] staging: iio: update TODO

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 28, 2020 at 05:36:15PM +0000, Jonathan Cameron wrote:
> On Tue, 25 Feb 2020 20:19:33 +0530
> Rohit Sarkar <rohitsarkar5398@xxxxxxxxx> wrote:
> 
> > since there are no uses of the old GPIO API, remove the item from the
> > TODO and some new items.
> > 
> > Changes from v1:
> > Add work item mentioned by Alexandru in https://marc.info/?l=linux-iio&m=158261515624212&w=2
> 
> My main issue here is we are adding to the "staging" todo,
> a list of tasks that are relevant to all drivers, not those
> in staging alone.

While I was making this patch I actually had the same concerns.
> Please break this into a simple patch removing the gpio stuff
> that is no longer relevant and a second patch to propose additions.
> That way I can pick up the uncontroversial part and we can talk
> further about whether it makes sense to put system wide TODO entries
> in here.

Makes sense, will do.

> Thanks,
> 
> Jonathan
> 
Thanks, Rohit
> > 
> > Signed-off-by: Rohit Sarkar <rohitsarkar5398@xxxxxxxxx>
> > ---
> >  drivers/staging/iio/TODO | 18 ++++++++++++------
> >  1 file changed, 12 insertions(+), 6 deletions(-)
> > 
> > diff --git a/drivers/staging/iio/TODO b/drivers/staging/iio/TODO
> > index 1b8ebf2c1b69..e54510c2ef5f 100644
> > --- a/drivers/staging/iio/TODO
> > +++ b/drivers/staging/iio/TODO
> > @@ -1,11 +1,17 @@
> > -2018-04-15
> > +2020-02-25
> >  
> > -All affected drivers:
> > -Convert all uses of the old GPIO API from <linux/gpio.h> to the
> > -GPIO descriptor API in <linux/gpio/consumer.h> and look up GPIO
> > -lines from device tree, ACPI or board files, board files should
> > -use <linux/gpio/machine.h>.
> > +- Documentation
> > +  - Binding docs for devices that are obviously used via device tree
> > +  - Yaml conversions for abandoned drivers
> > +  - ABI Documentation
> > +  - Audit driviers/iio/staging/Documentation
> >  
> > +- Replace iio_dev->mlock by either a local lock or use iio_claim_direct.
> > +  (Requires analysis of the purpose of the lock.)
> > +
> > +- Converting drivers from device tree centric to more generic property handlers
> > +  Refactor old platform_data constructs from drivers and convert it to state
> > +  struct and using property handlers and readers.
> >  
> >  ADI Drivers:
> >  CC the device-drivers-devel@xxxxxxxxxxxxxxxxxxxx mailing list when
> 
> 



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux