On Tue, Feb 11, 2020 at 11:54:17AM +0100, Fabrice Gasnier wrote: > On 2/10/20 6:45 PM, William Breathitt Gray wrote: > > On Mon, Feb 10, 2020 at 06:19:58PM +0100, Fabrice Gasnier wrote: > >> Add suspend/resume PM sleep ops. When going to low power, enforce the > >> counter isn't active. Gracefully restore its state upon resume in case > >> it's been left enabled prior to suspend. > >> > >> Acked-by: William Breathitt Gray <vilhelm.gray@xxxxxxxxx> > >> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@xxxxxx> > >> --- > >> Changes in v2: > >> - Don't refuse to suspend in case the counter has been left enabled. > >> Gracefully disable it and restore its state upon resume. > >> --- > >> drivers/counter/stm32-timer-cnt.c | 63 +++++++++++++++++++++++++++++++++++++++ > >> 1 file changed, 63 insertions(+) > >> > >> diff --git a/drivers/counter/stm32-timer-cnt.c b/drivers/counter/stm32-timer-cnt.c > >> index 3eafcce..50496f4 100644 > >> --- a/drivers/counter/stm32-timer-cnt.c > >> +++ b/drivers/counter/stm32-timer-cnt.c > >> @@ -12,6 +12,7 @@ > >> #include <linux/iio/types.h> > > > > Unrelated to your patch but it caught my eye: are iio headers necessary > > for this file? I suspect they are not needed since this driver does not > > make use of the IIO interface. > > Hi William, > > Yes, you're right. Thanks for pointing this! > I'll push a patch on top of this one to fix it. BTW, I'm not sure if > this needs to be a marked as a fix, as this seems a quite minor issue? > > Best Regards, > Fabrice No need for a Fixes tag in this case since this is not a bug fix, but rather just a minor clean up of the included headers. Thanks, William Breathitt Gray
