On Tue, 28 Jan 2020 14:30:46 +0100, David Heidelberg wrote: > This commit add dt-bindings support to al3320a driver and vendor-prefix > dynaimage. > Partly based on unmerged commit: > "iio: Add Dyna-Image AP3223 ambient light and proximity driver" > > Signed-off-by: David Heidelberg <david@xxxxxxx> > --- > .../bindings/iio/light/al3320a.yaml | 40 +++++++++++++++++++ > .../devicetree/bindings/vendor-prefixes.yaml | 2 + > 2 files changed, 42 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/light/al3320a.yaml > My bot found errors running 'make dt_binding_check' on your patch: Documentation/devicetree/bindings/display/simple-framebuffer.example.dts:21.16-37.11: Warning (chosen_node_is_root): /example-0/chosen: chosen node must be at root node Documentation/devicetree/bindings/iio/light/al3320a.example.dts:20.17-30: Warning (reg_format): /example-0/i2c/al3320a@1c:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) Documentation/devicetree/bindings/iio/light/al3320a.example.dt.yaml: Warning (pci_device_bus_num): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/iio/light/al3320a.example.dts:17.5-24.11: Warning (i2c_bus_bridge): /example-0/i2c: incorrect #address-cells for I2C bus Documentation/devicetree/bindings/iio/light/al3320a.example.dts:17.5-24.11: Warning (i2c_bus_bridge): /example-0/i2c: incorrect #size-cells for I2C bus Documentation/devicetree/bindings/iio/light/al3320a.example.dt.yaml: Warning (i2c_bus_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/iio/light/al3320a.example.dt.yaml: Warning (i2c_bus_reg): Failed prerequisite 'i2c_bus_bridge' Documentation/devicetree/bindings/iio/light/al3320a.example.dt.yaml: Warning (spi_bus_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/iio/light/al3320a.example.dts:18.24-23.15: Warning (avoid_default_addr_size): /example-0/i2c/al3320a@1c: Relying on default #address-cells value Documentation/devicetree/bindings/iio/light/al3320a.example.dts:18.24-23.15: Warning (avoid_default_addr_size): /example-0/i2c/al3320a@1c: Relying on default #size-cells value /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/light/al3320a.example.dt.yaml: al3320a@1c: 'interrupt' is a required property See https://patchwork.ozlabs.org/patch/1230353 Please check and re-submit.