Jonathan
Thanks for the review. I was on holiday
On 12/23/19 8:44 AM, Jonathan Cameron wrote:
On Tue, 17 Dec 2019 08:07:30 -0600
Dan Murphy <dmurphy@xxxxxx> wrote:
Add the TI DAC8771 DT binding.
Datasheet:
http://www.ti.com/lit/ds/symlink/dac8771.pdf
Signed-off-by: Dan Murphy <dmurphy@xxxxxx>
CC: Rob Herring <robh+dt@xxxxxxxxxx>
---
.../bindings/iio/dac/ti,dac8771.yaml | 89 +++++++++++++++++++
1 file changed, 89 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/dac/ti,dac8771.yaml
diff --git a/Documentation/devicetree/bindings/iio/dac/ti,dac8771.yaml b/Documentation/devicetree/bindings/iio/dac/ti,dac8771.yaml
new file mode 100644
index 000000000000..6aba6789d36c
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/dac/ti,dac8771.yaml
@@ -0,0 +1,89 @@
+# SPDX-License-Identifier: GPL-2.0
If possible, it is preferred for new bindings to be dual licensed as
(GPL-2.0-only OR BSD-2-Clause)
Ack
+# Copyright (C) 2019 Texas Instruments Incorporated
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/bindings/iio/dac/ti,dac8771.yaml#";
+$schema: "http://devicetree.org/meta-schemas/core.yaml#";
+
+title: Texas Instruments DAC8771
+
+maintainers:
+ - Dan Murphy <dmurphy@xxxxxx>
+
+description: |
+ The DAC8771 is a single channel, precision, fully integrated 16-bit digital
+ to analog converter (DAC) with adaptive power management, and is designed to
+ meet the requirements of industrial control applications.
+
+ Specifications can be found at:
+ http://www.ti.com/lit/ds/symlink/dac8771.pdf
+
+properties:
+ compatible:
+ enum:
+ - ti,dac8771
+
+ reg:
+ maxItems: 1
+
+ reset-gpios:
+ description: |
+ GPIO used for hardware reset.
+
+ loaddacs-gpios:
+ description: |
+ GPIO used to shift the data from the SPI FIFO to the processing engine.
+
+ spi-max-frequency:
+ maximum: 25000000
+
+ vref-supply:
+ description: Phandle to the external reference voltage supply.
+
+ ti,output-range:
+ description: Output range of the DAC
+ 0 - Voltage output 0 to +5 V (default)
Hmm. I'm never keen on opaque bindings, but sometimes things
are just too complex to break out as individual fields.
So I guess this is the best we can do.
Yes that is true. These values are the same as the ones in the data sheet.
It would have been a simpler binding if the current values were not
nested with the voltage values.
Dan
