2019年12月12日(木) 0:32 Andy Shevchenko <andy.shevchenko@xxxxxxxxx>: > > On Wed, Dec 11, 2019 at 4:39 PM Akinobu Mita <akinobu.mita@xxxxxxxxx> wrote: > > > > The asus-wmi driver doesn't implement the thermal device functionality > > directly, so including <linux/thermal.h> just for DECI_KELVIN_TO_CELSIUS() > > is a bit odd. > > > > This switches the asus-wmi driver to use deci_kelvin_to_millicelsius() in > > <linux/units.h>. > > > @@ -33,7 +33,7 @@ > > #include <linux/seq_file.h> > > #include <linux/platform_data/x86/asus-wmi.h> > > #include <linux/platform_device.h> > > -#include <linux/thermal.h> > > +#include <linux/units.h> > > #include <linux/acpi.h> > > #include <linux/dmi.h> > > Similar comment about ordering. Can we move it to the end after dmi.h? OK. > > - return sprintf(buf, "%d\n", value); > > > + return sprintf(buf, "%ld\n", > > %d -> %ld must be explained in the commit message (e.g. "due to > function returned type). OK. > > + deci_kelvin_to_millicelsius(value & 0xFFFF)); > > I prefer to have this in one line. It causes line over 80 characters. We had the same conversation in v1 :)
