On Mon, 2019-12-02 at 14:01 +0100, Lars Möllendorf wrote:
>
Hey Lars,
Thank you for the patch.
Could you add a description of the problem in the commit description?
You did a really great job on describing it via email earlier, and it would
be great to have it in the git history as well.
Also, this patch is marked 1/3 ; curios: are there 2 more patches in a set?
Sometimes, some patches get lost via email clients/servers.
Maybe Jonathan [or someone else] has some more points to this.
Thanks
Alex
> Signed-off-by: Lars Möllendorf <lars.moellendorf@xxxxxxxxxx>
> ---
> drivers/iio/industrialio-buffer.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/industrialio-buffer.c
> b/drivers/iio/industrialio-buffer.c
> index 5d05c38c4ba9..2f037cd59d53 100644
> --- a/drivers/iio/industrialio-buffer.c
> +++ b/drivers/iio/industrialio-buffer.c
> @@ -546,7 +546,7 @@ static int iio_compute_scan_bytes(struct iio_dev
> *indio_dev,
> const unsigned long *mask, bool timestamp)
> {
> unsigned bytes = 0;
> - int length, i;
> + int length, i, largest = 0;
>
> /* How much space will the demuxed element take? */
> for_each_set_bit(i, mask,
> @@ -554,13 +554,17 @@ static int iio_compute_scan_bytes(struct iio_dev
> *indio_dev,
> length = iio_storage_bytes_for_si(indio_dev, i);
> bytes = ALIGN(bytes, length);
> bytes += length;
> + largest = max(largest, length);
> }
>
> if (timestamp) {
> length = iio_storage_bytes_for_timestamp(indio_dev);
> bytes = ALIGN(bytes, length);
> bytes += length;
> + largest = max(largest, length);
> }
> +
> + bytes = ALIGN(bytes, largest);
> return bytes;
> }
>
> --
> 2.23.0
>
