On Thu, 14 Nov 2019 11:51:56 +0100 Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> wrote: > Hello, > > this is v2 of a series sent earlier starting with Message-id: > 20191111214025.18310-1-u.kleine-koenig@xxxxxxxxxxxxxx and addresses the > comments by Alexandru Ardelean. I'm a bit naughty here because I didn't > carry out all suggestions. So I didn't use ...-spi.c and -i2c.c as file > names, because this isn't about a single chip supporting both, but two > different ones supporting only one bus each. So I thought ltc2496.c, > ltc2497.c and ltc249x.c was fine. Not using the particular naming Alex suggested is fine, but wild cards in names is not. It's gone wrong far too often in the past. Much better to just pick a supported part and stick to that for naming. Obviously that's tricky here as you want to reuse the same name hence.. Clunky though it may seem ltc2497-core.c ltc2497 and ltc2496 would be my suggestion.. > > Also I didn't merge the binding docs of ltc2496 and ltc2497 for the same > reason. I'm still not entirely happy with the (now) yaml document. I'd > like to have a statement that says: This is an spi device, so it might > have all the properties described in > Documentation/devicetree/bindings/spi/spi-controller.yaml for an SPI > device. I don't think the is any way of doing this. For standard elements you normally just list them with no help etc. > > Uwe Kleine-König (3): > iio: adc: ltc2496: provide device tree binding document > iio: adc: ltc2497: split protocol independent part in a separate > module > iio: adc: new driver to support Linear technology's ltc2496 > > .../bindings/iio/adc/lltc,ltc2496.yaml | 30 +++ > MAINTAINERS | 2 +- > drivers/iio/adc/Kconfig | 10 + > drivers/iio/adc/Makefile | 3 +- > drivers/iio/adc/ltc2496.c | 100 +++++++ > drivers/iio/adc/ltc2497.c | 237 ++--------------- > drivers/iio/adc/ltc249x.c | 244 ++++++++++++++++++ > drivers/iio/adc/ltc249x.h | 18 ++ > 8 files changed, 433 insertions(+), 211 deletions(-) > create mode 100644 Documentation/devicetree/bindings/iio/adc/lltc,ltc2496.yaml > create mode 100644 drivers/iio/adc/ltc2496.c > create mode 100644 drivers/iio/adc/ltc249x.c > create mode 100644 drivers/iio/adc/ltc249x.h > > > base-commit: 31f4f5b495a62c9a8b15b1c3581acd5efeb9af8c
