This patch-set addresses some issues, where [when making the functions inline], the GCC [especially for x86_64] compilers start to report `-Wmaybe-unitialized` warnings/errors. The warnings are valid from a general stand-point, but are also false-positives, as the ADIS read functions return 0 or negative values. So for most cases `ret < 0` is fine [as is done in many drivers]. To appease the compiler, this changeset converts `if (ret < 0)` -> `if (ret)` [which is also a valid check] There are also 2 checkpatch complaints addressed. And lastly, 3 minor fixes. In some cases, the value of the ADIS read function should be checked for 0 (success) and only then assign the read buffer/value. These also contain Fixes tags. Alexandru Ardelean (10): iio: gyro: adis16136: check ret val for non-zero vs less-than-zero iio: imu: adis16400: check ret val for non-zero vs less-than-zero iio: imu: adis16460: check ret val for non-zero vs less-than-zero iio: imu: adis16480: check ret val for non-zero vs less-than-zero iio: imu: adis: check ret val for non-zero vs less-than-zero iio: imu: adis16480: fix indentation of return statement iio: imu: adis16480: prefer `unsigned int` over `unsigned` iio: imu: adis16480: assign bias value only if operation succeeded iio: imu: adis: assign read val in debugfs hook only if op successful iio: imu: adis: assign value only if return code zero in read funcs drivers/iio/gyro/adis16136.c | 24 +++++++++++------------ drivers/iio/imu/adis.c | 5 +++-- drivers/iio/imu/adis16400.c | 22 ++++++++++----------- drivers/iio/imu/adis16460.c | 8 ++++---- drivers/iio/imu/adis16480.c | 38 +++++++++++++++++++----------------- include/linux/iio/imu/adis.h | 6 ++++-- 6 files changed, 54 insertions(+), 49 deletions(-) -- 2.20.1
