Re: [PATCH 4/4] iio: adc: ina2xx: Use label proper for device identification

[Phil Reid <preid@xxxxxxxxxxxxxxxxx>]

On 20/08/2019 22:11, Michal Simek wrote:
> Add support for using label property for easier device identification via
> iio framework.
>
> Signed-off-by: Michal Simek <michal.simek@xxxxxxxxxx>
> ---
>
>   drivers/iio/adc/ina2xx-adc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/ina2xx-adc.c b/drivers/iio/adc/ina2xx-adc.c
> index 7c7c63677bf4..077c54915f70 100644
> --- a/drivers/iio/adc/ina2xx-adc.c
> +++ b/drivers/iio/adc/ina2xx-adc.c
> @@ -1033,7 +1033,7 @@ static int ina2xx_probe(struct i2c_client *client,
>   	snprintf(chip->name, sizeof(chip->name), "%s-%s",
>   		 client->name, dev_name(&client->dev));
>   
> -	indio_dev->name = chip->name;
> +	indio_dev->name = of_get_property(np, "label", NULL) ? : chip->name;
>   	indio_dev->setup_ops = &ina2xx_setup_ops;
>   
>   	buffer = devm_iio_kfifo_allocate(&indio_dev->dev);
I like this personally. It'd be nice if it was a core function so
it could be an opt in to any iio device.

Don't know how well received that'd be thou.


--
Regards
Phil Reid