On 15.07.19 23:10, Lorenzo Bianconi wrote:
>> Move some register definitions to the per-device array of struct
>> st_lsm6dsx_sensor_settings in order to simplify adding new sensor
>> devices to the driver.
>>
>> Also, remove completely unused register definitions.
>>
>
> Hi Martin,
>
> just few comments inline
>
> Regards,
> Lorenzo
>
>> Signed-off-by: Martin Kepplinger <martin.kepplinger@xxxxxxx>
>> ---
>> drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h | 6 ++++
>> drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 31 ++++++++++++++------
>> 2 files changed, 28 insertions(+), 9 deletions(-)
>>
>> diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h
>> index c14bf533b66b..f072ac14f213 100644
>> --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h
>> +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h
>> @@ -196,6 +196,9 @@ struct st_lsm6dsx_ext_dev_settings {
>> /**
>> * struct st_lsm6dsx_settings - ST IMU sensor settings
>> * @wai: Sensor WhoAmI default value.
>> + * @reg_int1_addr: Control Register address for INT1
>> + * @reg_int2_addr: Control Register address for INT2
>> + * @reg_reset_addr: register address for reset/reboot
>> * @max_fifo_size: Sensor max fifo length in FIFO words.
>> * @id: List of hw id/device name supported by the driver configuration.
>> * @decimator: List of decimator register info (addr + mask).
>> @@ -206,6 +209,9 @@ struct st_lsm6dsx_ext_dev_settings {
>> */
>> struct st_lsm6dsx_settings {
>> u8 wai;
>> + u8 reg_int1_addr;
>> + u8 reg_int2_addr;
>> + u8 reg_reset_addr;
>
> could you please rename them in int1_addr, int2_addr and reset_addr in order to
> be inline with other st_lsm6dsx_settings fields?
>
sure. thanks for reviewing!
martin
