Hi, On Mon, Jun 24, 2019 at 3:53 PM Gwendal Grignou <gwendal@xxxxxxxxxxxx> wrote: > > -static int read_ec_accel_data(struct cros_ec_accel_legacy_state *st, > - unsigned long scan_mask, s16 *data) > +int cros_ec_accel_legacy_read_cmd(struct iio_dev *indio_dev, > + unsigned long scan_mask, s16 *data) As found by 0day (see https://crrev.com/c/1678822), the cros_ec_accel_legacy_read_cmd() should have been static. I presume this will cause less confusion if a maintainer just fixes this up when landing the patch so Gwendal shouldn't send out a new version to fix it. ...but if this is not the case then yell! :-) -Doug
