Hi, On Thu, Jun 20, 2019 at 7:41 PM Gwendal Grignou <gwendal@xxxxxxxxxxxx> wrote: > > To allow cros_ec iio core library to be used with legacy device, add a > vector to rotate sensor data if necessary: legacy devices are not > reporting data in HTML5/Android sensor referential. > > On veyron minnie, check chrome detect tablet mode and rotate > screen in tablet mode. The above sentence is still a little strange. You just took the "TEST=" out but still left the testing instructions? They sound odd like this. You could just drop it, or perhaps instead change to: This change is part of a set of changes needed to let Chrome detect tablet mode and screen rotation on rk3288-veyron-minnie. > Signed-off-by: Gwendal Grignou <gwendal@xxxxxxxxxxxx> > --- > drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c | 4 ++++ > include/linux/iio/common/cros_ec_sensors_core.h | 1 + > 2 files changed, 5 insertions(+) I'm decidedly a non-expert here, but since I had nitpicks on patch #1 and my nitpicks have been addressed, feel free to add: Douglas Anderson <dianders@xxxxxxxxxxxx>
