On 2019/6/16 21:11, Jonathan Cameron wrote:
> On Fri, 14 Jun 2019 23:28:46 +0800
> YueHaibing <yuehaibing@xxxxxxxxxx> wrote:
>
>> Fix build error:
>>
>> drivers/staging/iio/addac/adt7316.c: In function adt7316_store_update_DAC:
>> drivers/staging/iio/addac/adt7316.c:949:3: error: implicit declaration of
>> function gpiod_set_value; did you mean gpio_set_value? [-Werror=implicit-function-declaration]
>> gpiod_set_value(chip->ldac_pin, 0);
>>
>> drivers/staging/iio/addac/adt7316.c: In function adt7316_setup_irq:
>> drivers/staging/iio/addac/adt7316.c:1807:13: error: implicit declaration of
>> function irqd_get_trigger_type; did you mean devm_iio_trigger_free? [-Werror=implicit-function-declaration]
>> irq_type = irqd_get_trigger_type(irq_get_irq_data(chip->bus.irq));
>>
>> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
>> Fixes: 7f6b6d553df7 ("Staging: iio: adt7316: Add all irq related code in adt7316_irq_setup()")
>> Fixes: c63460c4298f ("Staging: iio: adt7316: Use device tree data to set ldac_pin")
>> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
> Hi yuehaibing,
>
> You were second to send a fix for this. I've had it in my
> fixes branch since last week, but not done a pull request quite yet.
> I'll probably send it out later today.
Sorry, our robot report this again and I forgot this ...
>
> https://patchwork.kernel.org/patch/10978301/
>
> Thanks,
>
> Jonathan
>
>> ---
>> drivers/staging/iio/addac/adt7316.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c
>> index 37ce563..9d3d159 100644
>> --- a/drivers/staging/iio/addac/adt7316.c
>> +++ b/drivers/staging/iio/addac/adt7316.c
>> @@ -16,6 +16,8 @@
>> #include <linux/i2c.h>
>> #include <linux/rtc.h>
>> #include <linux/module.h>
>> +#include <linux/irq.h>
>> +#include <linux/gpio/consumer.h>
>>
>> #include <linux/iio/iio.h>
>> #include <linux/iio/events.h>
>
>
> .
>
