On 6/11/19 8:28 AM, Ardelean, Alexandru wrote: > On Mon, 2019-06-10 at 10:23 -0600, Robert Hancock wrote: >> [External] >> >> >> Since the XADC logic can be used with standalone Xilinx FPGAs, this >> driver can potentially be used with many different platforms, not just >> the Zynq and MicroBlaze platforms this driver was allowed to be built >> for. There should be no platform-specific code in this driver, so just >> delete the platform dependency. >> >> Signed-off-by: Robert Hancock <hancock@xxxxxxxxxxxxx> >> --- >> >> This is an updated version of an earlier patch "iio: adc: xilinx: support all >> ARM platforms", but this one just deletes the platform restriction entirely >> as it seems unnecessary. >> >> drivers/iio/adc/Kconfig | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig >> index f96a770..7e32862 100644 >> --- a/drivers/iio/adc/Kconfig >> +++ b/drivers/iio/adc/Kconfig >> @@ -1085,7 +1085,6 @@ config VIPERBOARD_ADC >> >> config XILINX_XADC >> tristate "Xilinx XADC driver" >> - depends on ARCH_ZYNQ || MICROBLAZE || COMPILE_TEST > > Just curios here: is `depends COMPILE_TEST` needed so that this gets included in a compile-test build ? > I'm somewhat vague on Linux's makefile logic/structure. COMPILE_TEST enables the driver for compile testing if it is not already enabled otherwise. Now that the driver has no dependencies at all it will always be enabled, which includes compile testing.
