Le 07/05/2019 à 21:53, Adam Michaelis a écrit :
On Sun, May 5, 2019 at 9:42 AM Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
On Thu, 2 May 2019 11:14:29 -0500
Adam Michaelis <adam.michaelis@xxxxxxxxxxxxxxxxxxx> wrote:
Adds device tree parameter to set the configuration read-back bit
in the configuration register to tell the AD7949 to include the value of
the configuration register at the time the current sample was acquired
when reading from the part.
Further work must be done to make read-back information available to
consumer.
This needs some explanation of why it is useful at all. I'm certainly unclear
on why it would be useful to configure this at boot time.
Code looks fine.
Jonathan
The configuration read-back feature is being maintained from the
original version of this driver. Before adding the device tree entry,
there was no way to change this setting other than debugfs raw access
to the SPI interface, and there is still no access to the returned
configuration data should the feature be enabled. I would be willing
to remove the feature altogether, but wanted to tread softly on
existing features.
Hi,
I added this feature for debug purpose but it is not used in our case
anymore because the driver and the device are working as expected.
But maybe we can use it the check if the config is correctly applied? I
don't know, it is probably useless to keep this feature here.
Regards,
Charles-Antoine Couret
