On Wed, 2019-05-22 at 12:36 +0200, Jiri Kosina wrote: > On Fri, 17 May 2019, hongyan.song@xxxxxxxxx wrote: > > > From: Song Hongyan <hongyan.song@xxxxxxxxx> Also commit summary "hid: remove NO_D3 flag for non Cherry Trail (CHT)" > > > > NO_D3 flag is set for CHV and the older platforms, the other > > platform > > suppose can enter D3, if have this NO_D3 flag set it can never > > enter D3 > > Could you please provide a little bit more descriptive changelog -- > namely > what observable problem is it fixing. In addition, I don't think this is a rc2+ release fix. Thanks, Srinivas > > > Signed-off-by: Song Hongyan <hongyan.song@xxxxxxxxx> > > --- > > drivers/hid/intel-ish-hid/ipc/pci-ish.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/hid/intel-ish-hid/ipc/pci-ish.c > > b/drivers/hid/intel-ish-hid/ipc/pci-ish.c > > index a6e1ee7..de1459b 100644 > > --- a/drivers/hid/intel-ish-hid/ipc/pci-ish.c > > +++ b/drivers/hid/intel-ish-hid/ipc/pci-ish.c > > @@ -154,7 +154,9 @@ static int ish_probe(struct pci_dev *pdev, > > const struct pci_device_id *ent) > > /* mapping IO device memory */ > > hw->mem_addr = pcim_iomap_table(pdev)[0]; > > ishtp->pdev = pdev; > > - pdev->dev_flags |= PCI_DEV_FLAGS_NO_D3; > > + /*This NO_D3 flag is only for CHV and older platforms*/ > > ... and while you're updating the changelog, please also stick a > space > before and after the comment mark. > > Thanks, >
Attachment:
smime.p7s
Description: S/MIME cryptographic signature
