On Mon, 2019-05-20 at 11:53 +0300, Alexandru Ardelean wrote:
> [External]
>
>
> On Sun, May 19, 2019 at 12:35 AM Bárbara Fernandes
> <barbara.fernandes@xxxxxx> wrote:
> >
> > Create structure of type of_device_id in order to register all devices
> > the driver is able to manage.
> >
>
> Hey,
>
> CC-ing my work-email
> There are some issues with it and mailing lists; I'll hopefully sort
> them out in the next weeks.
>
> > Signed-off-by: Bárbara Fernandes <barbara.fernandes@xxxxxx>
> > Signed-off-by: Melissa Wen <melissa.srw@xxxxxxxxx>
> > Co-developed-by: Melissa Wen <melissa.srw@xxxxxxxxx>
> > Signed-off-by: Wilson Sales <spoonm@xxxxxxxxxx>
> > Co-developed-by: Wilson Sales <spoonm@xxxxxxxxxx>
> > ---
> > drivers/staging/iio/cdc/ad7150.c | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/drivers/staging/iio/cdc/ad7150.c
> > b/drivers/staging/iio/cdc/ad7150.c
> > index 4b1c90e1b0ea..072094227e1b 100644
> > --- a/drivers/staging/iio/cdc/ad7150.c
> > +++ b/drivers/staging/iio/cdc/ad7150.c
> > @@ -655,11 +655,21 @@ static const struct i2c_device_id ad7150_id[] = {
> > {}
> > };
> >
> > +static const struct of_device_id ad7150_of_i2c_match[] = {
> > + { .compatible = "adi,ad7150" },
> > + { .compatible = "adi,ad7151" },
> > + { .compatible = "adi,ad7156" },
> > + {}
> > +};
> > +
> > +MODULE_DEVICE_TABLE(of, ad7150_of_i2c_match);
>
> nitpick: you don't need to add i2c in the name
> so, this could be just
> MODULE_DEVICE_TABLE(of, ad7150_of_match);
>
> but it's not a blocker for this;
Actually, disregard the above comment.
I just thought of some cases where it makes sense to have the i2c in the
name. So, ad7150_of_i2c_match is fine.
>
> So,
>
> Acked-by: Alexandru Ardelean <alexandru.ardelean@xxxxxxxxxx>
>
> > +
> > MODULE_DEVICE_TABLE(i2c, ad7150_id);
> >
> > static struct i2c_driver ad7150_driver = {
> > .driver = {
> > .name = "ad7150",
> > + .of_match_table = ad7150_of_i2c_match
> > },
> > .probe = ad7150_probe,
> > .id_table = ad7150_id,
> > --
> > 2.22.0.rc0.1.g337bb99195.dirty
> >
