Fill the read values in the buffer so we comply with the given index values. Fixes: 2a86487786b5c ("iio: adc: ti-ads8688: add trigger and buffer support") Signed-off-by: Sean Nyekjaer <sean@xxxxxxxxxx> --- drivers/iio/adc/ti-ads8688.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/iio/adc/ti-ads8688.c b/drivers/iio/adc/ti-ads8688.c index f9461070a74a..d9c354dbd7e4 100644 --- a/drivers/iio/adc/ti-ads8688.c +++ b/drivers/iio/adc/ti-ads8688.c @@ -387,13 +387,12 @@ static irqreturn_t ads8688_trigger_handler(int irq, void *p) struct iio_poll_func *pf = p; struct iio_dev *indio_dev = pf->indio_dev; u16 buffer[ADS8688_MAX_CHANNELS + sizeof(s64)/sizeof(u16)]; - int i, j = 0; + int bit; - for (i = 0; i < indio_dev->masklength; i++) { - if (!test_bit(i, indio_dev->active_scan_mask)) - continue; - buffer[j] = ads8688_read(indio_dev, i); - j++; + memset(buffer, 0, sizeof(buffer)); + + for_each_set_bit(bit, indio_dev->active_scan_mask, indio_dev->masklength) { + buffer[bit] = ads8688_read(indio_dev, bit); } iio_push_to_buffers_with_timestamp(indio_dev, buffer, -- 2.21.0