On Sun, 14 Apr 2019 11:35:04 -0700 Andrey Smirnov <andrew.smirnov@xxxxxxxxx> wrote: > Use devm_iio_device_register() and drop imx7d_adc_remove(). > > Signed-off-by: Andrey Smirnov <andrew.smirnov@xxxxxxxxx> > Cc: Jonathan Cameron <jic23@xxxxxxxxxx> > Cc: Hartmut Knaack <knaack.h@xxxxxx> > Cc: Lars-Peter Clausen <lars@xxxxxxxxxx> > Cc: Peter Meerwald-Stadler <pmeerw@xxxxxxxxxx> > Cc: Chris Healy <cphealy@xxxxxxxxx> > Cc: linux-iio@xxxxxxxxxxxxxxx > Cc: linux-kernel@xxxxxxxxxxxxxxx Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to poke at it. Thanks, Jonathan > --- > drivers/iio/adc/imx7d_adc.c | 13 +------------ > 1 file changed, 1 insertion(+), 12 deletions(-) > > diff --git a/drivers/iio/adc/imx7d_adc.c b/drivers/iio/adc/imx7d_adc.c > index c5b0dc7d0e49..958a34dd88ac 100644 > --- a/drivers/iio/adc/imx7d_adc.c > +++ b/drivers/iio/adc/imx7d_adc.c > @@ -554,7 +554,7 @@ static int imx7d_adc_probe(struct platform_device *pdev) > if (ret) > return ret; > > - ret = iio_device_register(indio_dev); > + ret = devm_iio_device_register(dev, indio_dev); > if (ret) { > dev_err(&pdev->dev, "Couldn't register the device.\n"); > return ret; > @@ -563,21 +563,10 @@ static int imx7d_adc_probe(struct platform_device *pdev) > return 0; > } > > -static int imx7d_adc_remove(struct platform_device *pdev) > -{ > - struct iio_dev *indio_dev = platform_get_drvdata(pdev); > - > - iio_device_unregister(indio_dev); > - > - return 0; > -} > - > - > static SIMPLE_DEV_PM_OPS(imx7d_adc_pm_ops, imx7d_adc_disable, imx7d_adc_enable); > > static struct platform_driver imx7d_adc_driver = { > .probe = imx7d_adc_probe, > - .remove = imx7d_adc_remove, > .driver = { > .name = "imx7d_adc", > .of_match_table = imx7d_adc_match,