Hi Boris, From: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx> Date: Tue, Apr 16, 2019 at 07:25:39 > > +MODULE_DEVICE_TABLE(i3c, st_lsm6dsx_i3c_ids); > > + > > +static struct i3c_driver st_lsm6dsx_driver = { > > + .driver.name = "st_lsm6dsx_i3c", > > + .probe = st_lsm6dsx_i3c_probe, > > + .id_table = st_lsm6dsx_i3c_ids, > > You should probably set the pm_ops here (st_lsm6dsx_pm_ops). Yes, I missed that. > > > +}; > > +module_i3c_driver(st_lsm6dsx_driver); > > + > > +MODULE_AUTHOR("Vitor Soares <vitor.soares@xxxxxxxxxxxx>"); > > +MODULE_DESCRIPTION("STMicroelectronics st_lsm6dsx i3c driver"); > > +MODULE_LICENSE("GPL v2"); > > + > > You can remove this blank line. Thanks for your feedback. Best regards, Vitor Soares