On Sun, Apr 7, 2019 at 4:15 AM Jonathan Cameron <jic23@xxxxxxxxxx> wrote: > > On Wed, 3 Apr 2019 00:03:24 -0700 > Andrey Smirnov <andrew.smirnov@xxxxxxxxx> wrote: > > > Initialization sequence performed in imx7d_adc_resume() is exactley > > the same as what's being done in imx7d_adc_probe(). Make use of the > > former in the latter to avoid code duplication. > > > > Signed-off-by: Andrey Smirnov <andrew.smirnov@xxxxxxxxx> > > Cc: Jonathan Cameron <jic23@xxxxxxxxxx> > > Cc: Hartmut Knaack <knaack.h@xxxxxx> > > Cc: Lars-Peter Clausen <lars@xxxxxxxxxx> > > Cc: Peter Meerwald-Stadler <pmeerw@xxxxxxxxxx> > > Cc: Chris Healy <cphealy@xxxxxxxxx> > > Cc: linux-iio@xxxxxxxxxxxxxxx > > Cc: linux-kernel@xxxxxxxxxxxxxxx > I'm not to going to apply this now, due to the ordering issue with the earlier > and later patches. However, it is fine in of itself. > > I do wonder if we want to rename resume to something else to reflect > it's new usage? imx7d_adc_enable perhaps? > Similar question for suspend in the next patch. Sure, will rename in v2. Thanks, Andrey Smirnov