Le lun. 8 avril 2019 à 11:38, Sebastian Reichel <sre@xxxxxxxxxx> a
écrit :
Hi Paul,
On Sun, Apr 07, 2019 at 09:07:57PM +0200, Paul Cercueil wrote:
Hi Sebastian,
Le dim. 7 avril 2019 à 18:52, Sebastian Reichel <sre@xxxxxxxxxx> a
écrit :
> Hi,
>
> On Sun, Mar 24, 2019 at 03:31:37PM +0000, Jonathan Cameron wrote:
> > On Sat, 23 Mar 2019 18:28:09 +0100
> > Artur Rojek <contact@xxxxxxxxxxxxxx> wrote:
> >
> > > Add a driver for battery present on Ingenic JZ47xx SoCs.
> > >
> > > Signed-off-by: Artur Rojek <contact@xxxxxxxxxxxxxx>
> > The IIO parts look fine to me.
> > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> >
> > Sebastian, assuming you are happy with this version,
>
> The driver itself looks ok. I'm a bit unhappy, that we already
have
> jz4740-battery. This driver is much cleaner, but does not yet seem
> to be ready to replace it. Artur Rojek what are your plans
regarding
> to the existing driver? Is there currently work going on migrating
> JZ47xx to DT?
Why do you think it's not ready? Feature-wise, it has everything we
need to replace jz4740-battery, which will be trashed as soon as the
LB60 board code is updated to use the new driver.
jz4740-battery has a few features not provided by your driver.
For example the gpio providing the charging status.
Artur sumitted a separate patchset for this functionality:
https://lkml.org/lkml/2019/2/26/501
Assuming you plan to trash the old driver soon:
Acked-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx>
We are working on porting the JZ47xx code to devicetree, yes. The
ultimate goal is to completely get rid of
arch/mips/jz4740/board-qi_lb60.c and arch/mips/jz4740/platform.c.
Ok, sounds good.
-- Sebastian
