On Sun, 2019-03-24 at 16:38 +0000, Jonathan Cameron wrote: > > diff --git a/drivers/iio/impedance-analyzer/ad5933.c b/drivers/iio/impedance-analyzer/ad5933.c trivial note: > > +static void ad5933_calc_out_ranges(struct ad5933_state *st) > > +{ > > + int i; > > + unsigned int normalized_3v3[4] = {1980, 198, 383, 970}; This could be static const which would make the code smaller.