Re: [PATCH 1/2] dt-bindings: iio: adc: Add bindings for TI ADS8344 A/DC chips

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jonathan,
 
 On sam., mars 16 2019, Jonathan Cameron <jic23@xxxxxxxxxx> wrote:

> On Fri, 15 Mar 2019 16:11:50 +0100
> Gregory CLEMENT <gregory.clement@xxxxxxxxxxx> wrote:
>
>> This adds device tree bindings for the TI ADS8344 A/DC chips.
>> 
>> Signed-off-by: Gregory CLEMENT <gregory.clement@xxxxxxxxxxx>
> Looks good to me, though io-channel-cells only needs to be 1 if
> you have consumers...  Otherwise, it shouldn't be there at all..

OK I will remove it then.

Thanks,

Gregory

>
> Jonathan
>
>> ---
>>  .../bindings/iio/adc/ti-ads8344.txt           | 21 +++++++++++++++++++
>>  1 file changed, 21 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/iio/adc/ti-ads8344.txt
>> 
>> diff --git a/Documentation/devicetree/bindings/iio/adc/ti-ads8344.txt b/Documentation/devicetree/bindings/iio/adc/ti-ads8344.txt
>> new file mode 100644
>> index 000000000000..6576c4fed7b7
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/iio/adc/ti-ads8344.txt
>> @@ -0,0 +1,21 @@
>> +* Texas Instruments ADS8344 A/DC chip
>> +
>> +Required properties:
>> + - compatible: Must be "ti,ads8344"
>> + - #io-channel-cells: Must be 1 as per ../iio-bindings.txt
>> + - reg: SPI chip select number for the device
>> + - vref-supply: phandle to a regulator node that supplies the
>> +   reference voltage
>> +
>> +Recommended properties:
>> + - spi-max-frequency: Definition as per
>> +		Documentation/devicetree/bindings/spi/spi-bus.txt
>> +
>> +Example:
>> +adc@0 {
>> +	compatible = "ti,ads8344";
>> +	reg = <0>;
>> +	#io-channel-cells = <1>;
>> +	vref-supply = <&refin_supply>;
>> +	spi-max-frequency = <10000000>;
>> +};
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux