Thank you for the review. I have a question inline. On Tue, Nov 06, 2018 at 09:18:06PM +0530, Himanshu Jha wrote: > On Tue, Nov 06, 2018 at 11:31:30AM +0000, Chris Coffey wrote: > > This patch adds driver support for the Microchip MCP41xxx/42xxx family > > of digital potentiometers: > > > > DEVICE Wipers Positions Resistance (kOhm) > > MCP41010 1 256 10 > > MCP41050 1 256 50 > > MCP41100 1 256 100 > > MCP42010 2 256 10 > > MCP42050 2 256 50 > > MCP42100 2 256 100 > > > > Datasheet: http://ww1.microchip.com/downloads/en/devicedoc/11195c.pdf > > > > Signed-off-by: Chris Coffey <cmc@xxxxxxxxxxxxx> > > --- > > .../bindings/iio/potentiometer/mcp41010.txt | 29 +++ > > WARNING: DT binding docs and includes should be a separate patch. > See: Documentation/devicetree/bindings/submitting-patches.txt > > Please run checkpatch.pl on this patch once. > Oops. I ran checkpatch.pl on the individual files, but neglected to run it on the patch file itself. I'll split the patch in v2. checkpatch.pl also reports a warning about the MAINTAINERS file: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? ... but looking through the tree, many IIO drivers don't have corresponding entries in MAINTAINERS; is this one of those checkpatch warnings that can be safely ignored? Or should all new drivers have a corresponding entry in MAINTAINERS? Thanks again, Chris
