On Sat, 3 Nov 2018 12:59:16 -0300 Renato Lui Geh <renatogeh@xxxxxxxxx> wrote: > Hi, > > >On Thu, 1 Nov 2018 15:02:32 +0000 > >"Ardelean, Alexandru" <alexandru.Ardelean@xxxxxxxxxx> wrote: > > > >> Good catch. > > That was actually Jonathan's catch. :) > > >> Acked-by: Alexandru Ardelean <alexandru.ardelean@xxxxxxxxxx> > > I read up on Acked-by on the kernel docs, as I didn't know exactly what > it meant, but I'm not so sure on how to proceed once the patch has been > acked. For future patches, do I add this Acked-by line on the patch's > message body? Or is this just an informal way of approval? It's formal. You put the line directly below your Signed-off-by: line if you are resending. If I pick up the patch I paste it in there whilst applying. > > >On the basis this has been broken for a long time, and you are clearly > >doing other nearby not fix work, I'm going to take this through the togreg > >tree rather than via the quicker fix path. It makes my life > >easier :) > > > >Applied to the togreg branch of iio.git and pushed out as testing for > >the autobuilders to play with it. > > So this means I should skip this patch on v4, right? Yes. Already in the tree so don't send it again. Thanks Jonathan > > Thanks, > Renato >
