On 10/25/2018 04:55 PM, Himanshu Jha wrote: > On Thu, Oct 25, 2018 at 11:26:36AM -0300, Renato Lui Geh wrote: >> Hi, >> >> Thanks for the quick review. :) >> >>> But please create one patch per issue and do not put unrelated changes into >>> the same patch. >> >> Should I resend this patch as a patchset containing the two changes? > > Yes! "One patch per change policy" > >>> Also your mail client seems to have replaced tabs in the patch with spaces, >>> this means the patch will not apply cleanly. Check the >>> Documentation/email-clients.txt file for some hints how to configure your >>> mail client so it will not break patches. >> >> From my end my original email patch appears to have tabs instead of >> spaces. I redownloaded my email and vim shows that the indentation has >> the ^I tab characters. But when downloading your reply it was converted >> to spaces. Am I missing something? > > Your patch applies fine. > > I think the problem is on Lars end due to Thunderbird. Yeah, looks like I need to read email-clients.txt... I think it is mis-rendered on my side due to the "Content-Type: ... format=flowed" in the header.
