On 10/18/2018 08:06 PM, Slawomir Stepien wrote: > On paź 18, 2018 19:31, Lars-Peter Clausen wrote: >> On 10/18/2018 01:49 PM, Slawomir Stepien wrote: >>> The custom build function ad7280_crc8_build_table is not needed. The >>> crc8_populate_msb function from linux/crc8.h will build the same crc >>> table. >>> >>> Signed-off-by: Slawomir Stepien <sst@xxxxxxxxx> >> >> This looks good, thanks. >> >> Acked-by: Lars-Peter Clausen <lars@xxxxxxxxxx> > > Thank you. > >> I supposed the code could be improved a bit further in a follow up patch by >> only having one global table since it will be the same for all instances. > > Yes that's a good idea. > How should I proceed? v3 or a separate commit based on the changes in this > commit? I think separate commit will be better, so I can make a good commit > message...or maybe put it all in a patch series with your ack added to this > change? Sorry I don't know the rules in such cases. I think Jonathan will pick this patch up soon. I'd wait until the patch has been applied and then send your next patch with further improvements to the driver.
