Re: [PATCH 1/2] iio:temperature: Add MAX31856 thermocouple support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Matt,

On Fri, Oct 12, 2018 at 12:44 AM Matt Ranostay
<matt.ranostay@xxxxxxxxxxxx> wrote:
>
> On Thu, Oct 11, 2018 at 3:10 AM Matt Weber
> <matthew.weber@xxxxxxxxxxxxxxxxxxx> wrote:
> >
> > From: Paresh Chaudhary <paresh.chaudhary@xxxxxxxxxxxxxxxxxxx>
> >
> > This patch adds support for Maxim MAX31856 thermocouple
> > temperature sensor support.
> >
> > More information can be found in:
> > https://www.maximintegrated.com/en/ds/MAX31856.pdf
> >
> > NOTE: Driver support only Comparator Mode.
> >
> > Signed-off-by: Paresh Chaudhary <paresh.chaudhary@xxxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Matt Weber <matthew.weber@xxxxxxxxxxxxxxxxxxx>
> > ---
> >
>
> Overall the driver looks nifty..  But just curious why you didn't use
> SPI regmap versus using direct spi read/writes?
>

No specific reason, we were more familiar with direct.  Good to note
though and we'll consider that next time or if we open the code back
up.

Matt



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux