On Tue, 3 Jul 2018 12:53:30 -0400 Maxime Roussin-Belanger <maxime.roussinbelanger@xxxxxxxxx> wrote: > On Sat, Jun 30, 2018 at 06:18:54PM +0100, Jonathan Cameron wrote: > > On Tue, 26 Jun 2018 13:01:09 -0400 > > Maxime Roussin-Bélanger <maxime.roussinbelanger@xxxxxxxxx> wrote: > > > > Hi Maxime > > > > Coming together nicely though a few minor things inline to add to Peter's > > review. > > > > It would make the device a lot more useful if we could provide a lux > > measurement. There is code out there to do this from the IR and ambient + IR > > channels, but licensing is going to be a potential issue. See inline. > > > > Jonathan > > > > > Signed-off-by: Maxime Roussin-Bélanger <maxime.roussinbelanger@xxxxxxxxx> > > > Reviewed-by: Jean-Francois Dagenais <dagenaisj@xxxxxxxxxxxx> > > > --- > > > Changes in v2: > > > - Add ABI documentation > > > - Drop part abstraction > > > - Clean up error handling style > > > > > > .../ABI/testing/sysfs-bus-iio-light-si1133 | 57 ++ > > > drivers/iio/light/Kconfig | 11 + > > > drivers/iio/light/Makefile | 1 + > > > drivers/iio/light/si1133.c | 809 ++++++++++++++++++ > > > 4 files changed, 878 insertions(+) > > > create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-light-si1133 > > > create mode 100644 drivers/iio/light/si1133.c > > > > > > diff --git a/Documentation/ABI/testing/sysfs-bus-iio-light-si1133 b/Documentation/ABI/testing/sysfs-bus-iio-light-si1133 > > > new file mode 100644 > > > index 000000000000..4533b5699c87 > > > --- /dev/null > > > +++ b/Documentation/ABI/testing/sysfs-bus-iio-light-si1133 > > > @@ -0,0 +1,57 @@ > > > +What: /sys/bus/iio/devices/iio:deviceX/in_intensity0_ir_small_raw > > > +KernelVersion: 4.18 > > > +Contact: linux-iio@xxxxxxxxxxxxxxx > > > +Description: > > > + Unit-less infrared intensity. The intensity is measured from 1 > > > + dark photodiode. "small" indicate the surface area capturing > > > + infrared. > > > + > > > +What: /sys/bus/iio/devices/iio:deviceX/in_intensity1_ir_med_raw > > > +KernelVersion: 4.18 > > > +Contact: linux-iio@xxxxxxxxxxxxxxx > > > +Description: > > > + Unit-less infrared intensity. The intensity is measured from 2 > > > + dark photodiode. "med" indicate the surface area capturing > > > + infrared. > > > + > > > +What: /sys/bus/iio/devices/iio:deviceX/in_intensity2_ir_large_raw > > > +KernelVersion: 4.18 > > > +Contact: linux-iio@xxxxxxxxxxxxxxx > > > +Description: > > > + Unit-less infrared intensity. The intensity is measured from 4 > > > + dark photodiode. "large" indicate the surface area capturing > > > + infrared. > > > > I'll admit I'm lost. Why would we use the different numbers of photodiodes? > > I get that the device supports them, but if there is a combination that is > > normally right, I'd like that one to be the one we don't use an extended name > > for (so generic code might look at it) > > > > I have no idea which one is the "right" one. Someone with more "light" background > could help me here. > > I can try to figure out which one seems like the "normal" one with some testing. That would be great. > ... > > > + > > > +What: /sys/bus/iio/devices/iio:deviceX/in_uvindex25_deep_raw > > > +KernelVersion: 4.18 > > > +Contact: linux-iio@xxxxxxxxxxxxxxx > > > +Description: > > > + UV light intensity index measuring the human skin's response to > > > + deep ultraviolet (DUV) wavelength of sunlight weighted according > > > + to the standardised CIE Erythemal Action Spectrum. > > > > I think we need a new modifier for this one. Please propose something suitable. > > I doubt it'll be the last time we see a sensor measuring this! > > > > I think something around "IIO_MOD_LIGHT_DUV" seems appropriate. It looks like a > lot of papers are using that acronym. > Sounds good to me. -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
