Re: [PATCH v5 0/4] iio: accel: adxl345: add calibration offset and sampling frequency support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jun 30, 2018 at 7:32 PM, Akinobu Mita <akinobu.mita@xxxxxxxxx> wrote:
> This patchset adds calibration offset and sampling frequency support for
> adxl345 driver with some preparatory changes.
>

One small comment to patch 5, otherwise FWIW,

Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>

> * v5 (Suggested by Andy Shevchenko)
> - Introduce constant for nHZ per HZ
> - Find an register setting without looping over all available frequencies
> - Allow all user supplied values and round to an available frequency
>
> * v4 (Suggested by Jonathan Cameron)
> - Stop abusing scan_index and keep using address field in iio_chan_spec
>
> * v3 (Suggested by Andy Shevchenko)
> - Define ADXL345_REG_DATA_AXIS(si) for cleaner register access
> - Define ADXL345_REG_OSF_AXIS(si) for cleaner register access
> - Calculate sampling frequency at runtime instead of having constant table
>
> * v2
> - Adjust the value for the calibbias to make the same scale as the _raw
>   measurement, and remove misused calibscale.
>
> Akinobu Mita (4):
>   iio: accel: adxl345: add link to datasheet
>   iio: accel: adxl345: convert address field usage in iio_chan_spec
>   iio: accel: adxl345: add calibration offset support
>   iio: accel: adxl345: add sampling frequency support
>
>  drivers/iio/accel/adxl345_core.c | 121 +++++++++++++++++++++++++++++++++++----
>  1 file changed, 110 insertions(+), 11 deletions(-)
>
> Cc: Eva Rachel Retuya <eraretuya@xxxxxxxxx>
> Cc: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> Cc: Jonathan Cameron <jic23@xxxxxxxxxx>
> --
> 2.7.4
>



-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux