Hi Peter, Thanks for your comments. > > there is no call to register_read() which is unlocked, maybe move the > locking into the function? Sure, I will lock/unlock mutexes in register_read and register_write functions. >> + .channel = ISL29501_MAGNITUDE_CHANNEL, > > .channel not needed? I use this channel field to distinguish between channels of the same type in read_raw and write_raw functions so I'd rather keep it, unless there is a better way? > 3.14 is a poor approximation :) > >> + *val2 = 6553600; Indeed :) I'll use IIO_VAL_INT_PLUS_NANO to express this with the best possible precision. I'll post a v3 soon taking your remarks into account. Mathieu -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
