Hi Dan, On Thu, Mar 8, 2018 at 10:31 AM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > The meson_sar_adc_lock() function is not supposed to hold the > "indio_dev->mlock" on the error path. > > Fixes: 3adbf3427330 ("iio: adc: add a driver for the SAR ADC found in Amlogic Meson SoCs") > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Acked-by: Martin Blumenstingl<martin.blumenstingl@xxxxxxxxxxxxxx> (even if I might be too late already since Jonathan already applied this patch) thank you for finding and fixing this! out of curiosity: did you find this with some tool (sparse?) or by looking at the code? Regards Martin -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html