On 03/07, Jonathan Cameron wrote: > On Tue, 6 Mar 2018 21:43:47 -0300 > Rodrigo Siqueira <rodrigosiqueiramelo@xxxxxxxxx> wrote: > > > The macro IIO_DEV_ATTR_CH_OFF is a wrapper for IIO_DEVICE_ATTR, with a > > tiny change in the name definition. This extra macro does not improve > > the readability and also creates some checkpatch errors. > > > > This patch fixes the checkpatch.pl errors: > > > > staging/iio/meter/ade7753.c:391: ERROR: Use 4 digit octal (0777) not > > decimal permissions > > staging/iio/meter/ade7753.c:395: ERROR: Use 4 digit octal (0777) not > > decimal permissions > > staging/iio/meter/ade7759.c:331: ERROR: Use 4 digit octal (0777) not > > decimal permissions > > staging/iio/meter/ade7759.c:335: ERROR: Use 4 digit octal (0777) not > > decimal permissions > > > > Signed-off-by: Rodrigo Siqueira <rodrigosiqueiramelo@xxxxxxxxx> > > Hmm. I wondered a bit about this one. It's a correct patch in of > itself but the interface in question doesn't even vaguely conform > to any of defined IIO ABI. Anyhow, it's still and improvement so > I'll take it. I am not sure if I understood the comment about the ABI. The meter interface is wrong because it uses things like IIO_DEVICE_ATTR? It should use iio_info together with *write_raw and *read_raw. Right? Is it the ABI problem that you refer? Thanks :) > Applied to the togreg branch of iio.git and pushed out as testing > for the autobuilders to play with it. > > I also added the removal of the header define which is no > longer used. > > Please note, following discussions with Michael, I am going to send > an email announcing an intent to drop these meter drivers next > cycle unless someone can provide testing for any attempt to > move them out of staging. I'm still taking patches on the basis > that 'might' happen - but I wouldn't focus on these until we > have some certainty on whether they will be around long term! > > Jonathan > > > --- > > drivers/staging/iio/meter/ade7753.c | 18 ++++++++++-------- > > drivers/staging/iio/meter/ade7759.c | 18 ++++++++++-------- > > 2 files changed, 20 insertions(+), 16 deletions(-) > > > > diff --git a/drivers/staging/iio/meter/ade7753.c b/drivers/staging/iio/meter/ade7753.c > > index c44eb577dc35..275e8dfff836 100644 > > --- a/drivers/staging/iio/meter/ade7753.c > > +++ b/drivers/staging/iio/meter/ade7753.c > > @@ -388,14 +388,16 @@ static IIO_DEV_ATTR_VPERIOD(0444, > > ade7753_read_16bit, > > NULL, > > ADE7753_PERIOD); > > -static IIO_DEV_ATTR_CH_OFF(1, 0644, > > - ade7753_read_8bit, > > - ade7753_write_8bit, > > - ADE7753_CH1OS); > > -static IIO_DEV_ATTR_CH_OFF(2, 0644, > > - ade7753_read_8bit, > > - ade7753_write_8bit, > > - ADE7753_CH2OS); > > + > > +static IIO_DEVICE_ATTR(choff_1, 0644, > > + ade7753_read_8bit, > > + ade7753_write_8bit, > > + ADE7753_CH1OS); > > + > > +static IIO_DEVICE_ATTR(choff_2, 0644, > > + ade7753_read_8bit, > > + ade7753_write_8bit, > > + ADE7753_CH2OS); > > > > static int ade7753_set_irq(struct device *dev, bool enable) > > { > > diff --git a/drivers/staging/iio/meter/ade7759.c b/drivers/staging/iio/meter/ade7759.c > > index 1decb2b8afab..c078b770fa53 100644 > > --- a/drivers/staging/iio/meter/ade7759.c > > +++ b/drivers/staging/iio/meter/ade7759.c > > @@ -328,14 +328,16 @@ static IIO_DEV_ATTR_ACTIVE_POWER_GAIN(0644, > > ade7759_read_16bit, > > ade7759_write_16bit, > > ADE7759_APGAIN); > > -static IIO_DEV_ATTR_CH_OFF(1, 0644, > > - ade7759_read_8bit, > > - ade7759_write_8bit, > > - ADE7759_CH1OS); > > -static IIO_DEV_ATTR_CH_OFF(2, 0644, > > - ade7759_read_8bit, > > - ade7759_write_8bit, > > - ADE7759_CH2OS); > > + > > +static IIO_DEVICE_ATTR(choff_1, 0644, > > + ade7759_read_8bit, > > + ade7759_write_8bit, > > + ADE7759_CH1OS); > > + > > +static IIO_DEVICE_ATTR(choff_2, 0644, > > + ade7759_read_8bit, > > + ade7759_write_8bit, > > + ADE7759_CH2OS); > > > > static int ade7759_set_irq(struct device *dev, bool enable) > > { > -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html