On Thu, Mar 8, 2018 at 10:45 AM, Himanshu Jha <himanshujha199640@xxxxxxxxx> wrote: > In preparation to enabling -Wvla, remove VLA usage and replace it > with fixed a fixed length array and therefore, prevent potential > stack overflow attacks. > > Fixed as a part of the discussion to remove all VLAs from the kernel: > https://lkml.org/lkml/2018/3/7/621 > > Cc: keescook@xxxxxxxxxxxx > Signed-off-by: Himanshu Jha <himanshujha199640@xxxxxxxxx> > --- > drivers/iio/potentiometer/ds1803.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/potentiometer/ds1803.c b/drivers/iio/potentiometer/ds1803.c > index 9b0ff4a..6bf12c9 100644 > --- a/drivers/iio/potentiometer/ds1803.c > +++ b/drivers/iio/potentiometer/ds1803.c > @@ -64,7 +64,7 @@ static int ds1803_read_raw(struct iio_dev *indio_dev, > struct ds1803_data *data = iio_priv(indio_dev); > int pot = chan->channel; > int ret; > - u8 result[indio_dev->num_channels]; > + u8 result[ARRAY_SIZE(ds1803_channels)]; It seems like num_channels is always ARRAY_SIZE(ds1803_channels). Could the entire field be dropped? -Kees > > switch (mask) { > case IIO_CHAN_INFO_RAW: > -- > 2.7.4 > -- Kees Cook Pixel Security -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
