On Sat, 2018-03-03 at 15:00 +0000, Jonathan Cameron wrote: > On Mon, 26 Feb 2018 12:47:28 +0200 > Daniel Baluta <daniel.baluta@xxxxxxxxx> wrote: > > > On Mon, Feb 26, 2018 at 9:44 AM, Ardelean, Alexandru > > <alexandru.Ardelean@xxxxxxxxxx> wrote: > > > On Sat, 2018-02-24 at 12:18 +0000, Jonathan Cameron wrote: > > > > On Fri, 16 Feb 2018 14:09:15 +0200 > > > > Alexandru Ardelean <alexandru.ardelean@xxxxxxxxxx> wrote: > > > > > > > > > This is a small cleanup of the driver's init code. > > > > > It does not fix anything. > > > > > > > > > > The `devm_iio_kfifo_allocate()` function is used instead of > > > > > `iio_kfifo_allocate()`. This removes the need for explicit deallocation of > > > > > the driver's iio_buffer, which will now be handled via > > > > > `iio_device_unregister()`. > > > > > > > > > > The `setup_ops` assignment has been moved into the `ad5933_probe()` call, > > > > > since it's a one-liner. > > > > > > > > > > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@xxxxxxxxxx> > > > > > --- > > > > > > > > > > Note: this change is based on top of `fixes-togreg-post-rc1` branch which > > > > > contains commit (7d2b8e6aaf9: staging: iio: ad5933: switch buffer mode to > > > > > software) > > > > > > > > It will take a few weeks for that to get to my togreg branch so please > > > > do remind me if it has and I seem to have forgotten this! > > > > > > > > Jonathan > > > > > > I'm a bit new to how things progress in the iio subtree. > > > [Curious] Is there a recommended branch that is regularly updated with accepted > > > patches ? > > > Or which branches do I need to rebase when submitting other patches ? > > > > > > Salut Alexandru, > > > > You can use the togreg branch of iio tree. > > That tends to only get updated fairly infrequently except when I'm doing > a pull request but that is 'in theory' the right branch to use. > > In practice, the only reason I'd change things in the testing branch > is a build failure or a comment from someone suggesting a reason to pull > a patch. Mind you I've been pretty bad at remembering to push that out > as well recently :( I only find out when I realise I didn't get a build > report from 0-day when I get to work on Monday. > I don't know about you guys, but I've always been terrible at following email threads after they go above a certain count. Which is why I am appreciative when using web-tools like Github, Gitlab, etc and using email mostly as a notification method. I admit there's usually some concern/resistance to considering these tools. [I usually refer to OpenWrt for a lot of examples, since I follow the project]. Currently, OpenWrt has 2 ways of accepting patches: 1 via Github, 1 via email + patchwork. The Github repo is just a mirror of the official repo. [AFAIK] Patches get applied to the official repo and then mirrored on Github. Alex > Jonathan > > > > > thanks, > > Daniel. > > ��.n��������+%������w��{.n�����{��(��)��jg��������ݢj����G�������j:+v���w�m������w�������h�����٥