Re: [PATCH] iio:dummy: Fix coding style in simple_dummy and evgen

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/21, Daniel Baluta wrote:
> On Wed, Feb 21, 2018 at 4:05 PM, Rodrigo Siqueira
> <rodrigosiqueiramelo@xxxxxxxxx> wrote:
> > This patch fixes the following checkpatch.pl warnings:
> >
> > drivers/iio/dummy/iio_simple_dummy.c:603: WARNING: Block comments should
> > align the * on each line
> > drivers/iio/dummy/iio_dummy_evgen.c:151: WARNING: Symbolic permissions
> > 'S_IWUSR' are not preferred. Consider using octal permissions '0200'...
> > drivers/iio/dummy/iio_simple_dummy.c:693: CHECK: Please use a blank line
> > after function/struct/union/enum declarations
> 
> You are trying to fix 3 things in one patch here. Please don't do that.
> 
> One patch per change please.

Even for a simple comment line fix?
 
> thanks,
> Daniel.
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux