Hi Mark,
On Tue, Jan 30, 2018 at 4:03 PM, Mark Brown <broonie@xxxxxxxxxx> wrote:
> On Tue, Jan 30, 2018 at 02:21:46PM +0100, Geert Uytterhoeven wrote:
>> If NO_DMA=y:
>>
>> ERROR: "bad_dma_ops" [drivers/iio/adc/stm32-dfsdm-adc.ko] undefined!
>>
>> Add a dependency on HAS_DMA to fix this.
>
> Once again I have to ask why we're doing this per driver and not having
> the few architectures that have this issue set something up.
Because doing so would lead us to
depends on COMPILE_TEST || HAS_DMA
in many places. Is that any better?
I agree we could indeed use DMA dummies in cases where a driver uses:
depends on ARCH_FOO || ARCH_BAR || COMPILE_TEST
depends on HAS_DMA
But we also have generic options like:
config ATA_BMDMA
bool "ATA BMDMA support"
depends on HAS_DMA
And even architecture-specific drivers for SoCs that may or not have DMA:
config HASH_DEV_STM32
tristate "Support for STM32 hash accelerators"
depends on ARCH_STM32
depends on HAS_DMA
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
