On 01/26/2018 07:19 PM, Andy Shevchenko wrote: > On Sun, Jan 14, 2018 at 10:32 PM, Milan Stevanovic > <milan.o.stevanovic@xxxxxxxxx> wrote: >> Add Linux device driver for TI single-channel CMOS >> 8/10/12-bit analog-to-digital converter with a >> high-speed serial interface. >> >> Signed-off-by: Milan Stevanovic <milan.o.stevanovic@xxxxxxxxx> > >> + * Analog Devices AD7466/7/8 AD7476/5/7/8 (A) SPI ADC driver >> + * TI ADC081S/ADC101S/ADC121S 8/10/12-bit SPI ADC driver > > Guys, I'm not sure I understood this mix. > > We have like few TI drivers here: > > drivers/iio/adc/ti-adc0832.c:352:module_spi_driver(adc0832_driver); > drivers/iio/adc/ti-adc084s021.c:269:module_spi_driver(adc084s021_driver); > drivers/iio/adc/ti-adc108s102.c:343:module_spi_driver(adc108s102_driver); > drivers/iio/adc/ti-adc12138.c:547:module_spi_driver(adc12138_driver); > drivers/iio/adc/ti-adc128s052.c:211:module_spi_driver(adc128_driver); > drivers/iio/adc/ti-adc161s626.c:276:module_spi_driver(ti_adc_driver); > drivers/iio/adc/ti-ads7950.c:519:module_spi_driver(ti_ads7950_driver); > drivers/iio/adc/ti-ads8688.c:481:module_spi_driver(ads8688_driver); > drivers/iio/adc/ti-tlc4541.c:266:module_spi_driver(tlc4541_driver); > > What's wrong with them? > > Is it here code duplication between two vendors? > Looking at this list ti-adc161s626 could probably be combined with the ad7476 driver. It fits the bill, single channel ADC with SPI interface and no control registers. -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
